Repository navigation
test: Wire wrapper, proxy, TLS skip-verify and service endpoints in the contract test services - #561
Merged
Conversation
…he contract test services Generated-by: termag
kinyoklion
marked this pull request as ready for review
November 3, 2026 18:17
keelerm84
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both contract test services (sync and async) now map the harness
wrapper,proxy.httpProxy,tls.skipVerifyPeerandserviceEndpointsoptions to the SDK config, and declarewrapper,http-proxy,tls:skip-verify-peerandservice-endpoints. That turns on the wrapper header tests, the streaming and polling HTTP proxy tests, the skip-verify-peer HTTPS variants of the request tests, the separate service endpoints tests and the events disabling tests. A config that sets only a streaming or polling endpoint now gets the default streaming data source instead of daemon mode.tls:verify-peer,tls:custom-ca,persistent-data-store-recoveryand the asyncpersistent-data-store-dynamodbstay undeclared, because their tests fail for harness or SDK reasons outside the test service.Supersedes #549.
Tested locally on both services against harness v2.42.0 and v3.2.0-alpha.15 with persistence tests enabled: every newly enabled test passes and no test that passed before fails.
Opened from termag
Note
Overview
Sync and async contract test client builders now translate harness
wrapper,proxy,tls.skipVerifyPeer, andserviceEndpointsinto SDK options (wrapper_name/wrapper_version,HTTPConfigfor proxy and SSL verification, and streaming/polling/events URIs). Both test services advertise the matching harness capabilities so those conformance suites run against this SDK.Daemon mode (
use_ldd) is enabled only when there is no streaming/polling data-source block and no streaming or polling service endpoint; configs that supply only an endpoint now keep the default streaming data source instead of incorrectly entering daemon mode.Reviewed by Cursor Bugbot for commit a9276c0. Bugbot is set up for automated code reviews on this repo. Configure here.